[libvirt] [PATCH v2 0/5] domainRename API implementation

[Michal Privoznik]

On 06.08.2015 12:21, Tomas Meszaros wrote:
> s is an effort to implement domain rename API. Presented patch series
> consists of the following: virDomainRename API implementation for qemu,
> implementation of the virsh command domrename and the additional support
> code.
> 
> The idea behind this endeavor is to provide convenient and safe way to rename
> a domain.
> 
> Instead of the:
> 
>     virsh dumpxml domain > domain.xml
>     (change domain name in domain.xml)
>     virsh undefine domain
>     virsh define domain.xml
> 
> user can simply type:
> 
>     virsh domrename foo bar
> 
> or call virDomainRename() API and domain "foo" will be renamed to "bar".
> 
> We currently support only renaming inactive domains without snapshots.
> Renaming procedure takes care of domain log, config, guest agent path and should
> be able to recover in case of failure.
> 
> I've been working on this functionality in collaboration with Michal Privoznik
> who is my mentor during the GSoC 2015. If you have any questions, ideas
> or criticism feel free to join the discussion.
> 
> 
> v2:
>  - removed guest agent path rename code
>  - removed rename permission
>  - added code for emitting undefined+renamed event for the old domain
> 
> 
> Tomas Meszaros (5):
>   Introduce virDomainRename API
>   virsh: Implement "domrename" command
>   domain_conf: Introducde virDomainObjListRenameAddNew() &
>     virDomainObjListRenameRemove()
>   Introduce new VIR_DOMAIN_EVENT_DEFINED_RENAMED event
>   qemu: Implement virDomainRename
> 
>  examples/object-events/event-test.c |   4 +
>  include/libvirt/libvirt-domain.h    |   4 +
>  src/access/viraccessperm.c          |   3 +-
>  src/access/viraccessperm.h          |   6 ++
>  src/conf/domain_conf.c              |  35 +++++++++
>  src/conf/domain_conf.h              |   5 ++
>  src/driver-hypervisor.h             |   5 ++
>  src/libvirt-domain.c                |  31 ++++++++
>  src/libvirt_private.syms            |   2 +
>  src/libvirt_public.syms             |   5 ++
>  src/qemu/qemu_driver.c              | 144 ++++++++++++++++++++++++++++++++++++
>  src/remote/remote_driver.c          |   1 +
>  src/remote/remote_protocol.x        |  17 ++++-
>  src/remote_protocol-structs         |   8 ++
>  tools/virsh-domain.c                |  63 +++++++++++++++-
>  tools/virsh.pod                     |   7 ++
>  16 files changed, 336 insertions(+), 4 deletions(-)
> 

I think this looks okay. Well, I have some findings in 1/5 but the rest
looks okay to me.

Michal