[libvirt] [PATCH 2/2] libvirt-admin: Generate symbols file

Guido Günther agx at sigxcpu.org
Thu Aug 20 08:50:43 UTC 2015


On Thu, Aug 20, 2015 at 02:46:18AM +0200, Michal Privoznik wrote:
> On 19.08.2015 14:39, Guido Günther wrote:
> > Since we're linking this into libvirtd we need some symbols to be public
> > but not part of the public API so mark them as
> > LIBVIRT_ADMIN_PRIVATE_<VERSION> as we do with libvirt.
> > 
> > Making all other symbols local makes sure we don't accidentally leak
> > unwanted ones.
> > ---
> >  configure.ac                   |  2 +-
> >  src/Makefile.am                | 20 ++++++++++++++++++--
> >  src/libvirt_admin.syms         | 18 ------------------
> >  src/libvirt_admin_private.syms | 14 ++++++++++++++
> >  src/libvirt_admin_public.syms  | 18 ++++++++++++++++++
> >  5 files changed, 51 insertions(+), 21 deletions(-)
> >  delete mode 100644 src/libvirt_admin.syms
> >  create mode 100644 src/libvirt_admin_private.syms
> >  create mode 100644 src/libvirt_admin_public.syms
> 
> 
> Cool! ACK to both. Thanks for solving that.

Pushed. Thanks,
 -- Guido




More information about the libvir-list mailing list