[libvirt] [PATCH 2/4] libvirt_lxc: Claim success for --help

[Daniel P. Berrange]

On Thu, Aug 27, 2015 at 03:06:52AM +0200, Michal Privoznik wrote:
> So far, if libvirt_lxc binary (usually to be found under
> /usr/libexec/) is run with --help, due to a missing line
> and our usual functions pattern, an 'uknown' error is returned.
> Yeah, the help is printed out, but we should not claim error.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/lxc/lxc_controller.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
> index a94e819..d36bc9b 100644
> --- a/src/lxc/lxc_controller.c
> +++ b/src/lxc/lxc_controller.c
> @@ -2613,6 +2613,7 @@ int main(int argc, char *argv[])
>              fprintf(stderr, "  -U FD, --share-uts FD\n");
>              fprintf(stderr, "  -h, --help\n");
>              fprintf(stderr, "\n");
> +            rc = 0;
>              goto cleanup;
>          }
>      }

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|