[libvirt] [libvirt-glib][PATCH] Drop unused finalize function

Christophe Fergeau cfergeau at redhat.com
Mon Dec 7 12:12:24 UTC 2015


Thanks for the follow-up, ACK.

Christophe

On Mon, Dec 07, 2015 at 12:48:13PM +0100, Michal Privoznik wrote:
> After 1225a160ac3b4 where I'm dropping some unused variables, the
> functions I was touching became sort of redundant too.
> Specifically, gvir_domain_disk_finalize() and
> gvir_domain_interface_finalize().
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  libvirt-gobject/libvirt-gobject-domain-disk.c      | 8 --------
>  libvirt-gobject/libvirt-gobject-domain-interface.c | 8 --------
>  2 files changed, 16 deletions(-)
> 
> diff --git a/libvirt-gobject/libvirt-gobject-domain-disk.c b/libvirt-gobject/libvirt-gobject-domain-disk.c
> index 7f34ebd..bb2a682 100644
> --- a/libvirt-gobject/libvirt-gobject-domain-disk.c
> +++ b/libvirt-gobject/libvirt-gobject-domain-disk.c
> @@ -49,16 +49,8 @@ gvir_domain_disk_error_quark(void)
>      return g_quark_from_static_string("gvir-domain-disk");
>  }
>  
> -static void gvir_domain_disk_finalize(GObject *object)
> -{
> -    G_OBJECT_CLASS(gvir_domain_disk_parent_class)->finalize(object);
> -}
> -
>  static void gvir_domain_disk_class_init(GVirDomainDiskClass *klass)
>  {
> -    GObjectClass *object_class = G_OBJECT_CLASS (klass);
> -
> -    object_class->finalize = gvir_domain_disk_finalize;
>      g_type_class_add_private(klass, sizeof(GVirDomainDiskPrivate));
>  }
>  
> diff --git a/libvirt-gobject/libvirt-gobject-domain-interface.c b/libvirt-gobject/libvirt-gobject-domain-interface.c
> index 443a2b6..beae11e 100644
> --- a/libvirt-gobject/libvirt-gobject-domain-interface.c
> +++ b/libvirt-gobject/libvirt-gobject-domain-interface.c
> @@ -49,16 +49,8 @@ gvir_domain_interface_error_quark(void)
>      return g_quark_from_static_string("gvir-domain-interface");
>  }
>  
> -static void gvir_domain_interface_finalize(GObject *object)
> -{
> -    G_OBJECT_CLASS(gvir_domain_interface_parent_class)->finalize(object);
> -}
> -
>  static void gvir_domain_interface_class_init(GVirDomainInterfaceClass *klass)
>  {
> -    GObjectClass *object_class = G_OBJECT_CLASS (klass);
> -
> -    object_class->finalize = gvir_domain_interface_finalize;
>      g_type_class_add_private(klass, sizeof(GVirDomainInterfacePrivate));
>  }
>  
> -- 
> 2.4.10
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151207/292cea93/attachment-0001.sig>


More information about the libvir-list mailing list