[libvirt] [PATCH 2/2] qemu: Add support for zero-detection writes

[Peter Krempa]

On Mon, Dec 14, 2015 at 15:42:24 +0100, Martin Kletzander wrote:
> On Mon, Dec 14, 2015 at 04:26:44PM +0300, Vasiliy Tolstov wrote:
> >2015-12-14 15:44 GMT+03:00 Vasiliy Tolstov <v.tolstov at selfip.ru>:
> >> Thanks, i'm try to test this patch series and get error:
> >> ОШИБКА: internal error: process exited while connecting to monitor:
> >> 2015-12-14T12:36:44.438611Z qemu-system-x86_64: -drive
> >> file=/dev/vg3/41459,if=none,id=drive-scsi0-0-0-0,format=raw,cache=none,discard=unmap,detect_zeros=unmap,aio=native:
> >> Block format 'raw' used by device 'drive-scsi0-0-0-0' doesn't support
> >> the option 'detect_zeros'
> >
> 
> Yes, exactly this needs to be squashed in, thanks for noticing earlier
> than I did :)
> 
> >
> >this is patch for patch =)
> >
> >diff --git a/debian/patches/libvirt-qemu-detect-zeros.patch
> >b/debian/patches/libvirt-qemu-detect-zeros.patch
> >index 582c49d..d86dee6 100644
> >--- a/debian/patches/libvirt-qemu-detect-zeros.patch
> >+++ b/debian/patches/libvirt-qemu-detect-zeros.patch
> >@@ -130,7 +130,7 @@ index d2f37e408bab..49b76adc416f 100644
> >
> > +    if (disk->detect_zeros) {

Also this variable should be renamed for consistency once we are getting
into this.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151214/06f17e12/attachment-0001.sig>