[libvirt] [PATCH 4/6] virsh: Create macro for "overwrite" and no-overwrite" options

[John Ferlan]

On 12/16/2015 10:32 AM, John Ferlan wrote:
> 
> [...]
> 
>>>
>>> So then in your opinion and using the same logic, patch 3 is also nixed?
>>> This one will get used in patch 6.
>>
>> With that use it will result in total 4 uses. I won't object if you fix
>> the macro name and remove the comma
>>
> 
> Hmm. by name change do you mean "OPT_POOL_FILE_COMMON",
> "OPT_POOL_OVERWRITE_COMMON", etc.?  I guess I was thinking less globally
> available macros, e.g. module specific rather than adding them to some
> more generally included virsh*.h file.
> 

nm... patch 2 comment... you'd rather see VSH_POOL_OPT_COMMON than
OPT_POOL_COMMON

John