[libvirt] [PATCH] qemu: Properly report error when cookin uuid not match the ctxt uuid

Ján Tomko jtomko at redhat.com
Thu Feb 5 07:14:56 UTC 2015


On Thu, Feb 05, 2015 at 11:42:26AM +0800, Luyao Huang wrote:
> Add the missing jump to the error label when cookin uuid
> does not match the ctxt uuid.
>

'cookie uuid' and 'ctxt uuid' don't seem clear enough to me.
I have reworded the commit message:

Add the missing jump to the error label when the uuid in the
migration cookie XML does not match the uuid of the migrated
domain.

> Signed-off-by: Luyao Huang <lhuang at redhat.com>
> ---
>  src/qemu/qemu_migration.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 8a8fa63..879b1bf 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -1147,6 +1147,7 @@ qemuMigrationCookieXMLParse(qemuMigrationCookiePtr mig,
>          virReportError(VIR_ERR_INTERNAL_ERROR,
>                         _("Incoming cookie data had unexpected UUID %s vs %s"),
>                         tmp, uuidstr);
> +        goto error;
>      }
>      VIR_FREE(tmp);
>  

ACK and pushed.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150205/8d02fb75/attachment-0001.sig>


More information about the libvir-list mailing list