[libvirt] [PATCH] Clarify behavior or virDomainDetachDevice

Eric Blake eblake at redhat.com
Mon Feb 23 22:17:17 UTC 2015


On 02/20/2015 04:39 AM, Ján Tomko wrote:
> Doucment that not all attributes are used for matching.

s/Doucment/Document/

> 
> https://bugzilla.redhat.com/show_bug.cgi?id=872028
> ---
>  src/libvirt-domain.c | 5 +++++
>  tools/virsh.pod      | 4 +++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 

> +++ b/tools/virsh.pod
> @@ -2441,7 +2441,9 @@ the device does not use managed mode.
>  
>  B<Note>: using of partial device definition XML files may lead to unexpected
>  results as some fields may be autogenerated and thus match devices other than
> -expected.
> +expected. Not every device attribute is checked when matching the device.
> +For example a network interface can be detatched if the mac and PCI addresses
> +match, even if the type does not.

s/detatched/detached/

(of course, now that I've read the rest of this thread, I see that you
aren't using this wording after all...)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150223/ade57593/attachment-0001.sig>


More information about the libvir-list mailing list