[libvirt] [PATCH] maint: in makefiles, $(top_srcdir)/src is verbose
Michal Privoznik
mprivozn at redhat.com
Thu Jan 8 09:25:25 UTC 2015
On 08.01.2015 01:07, Eric Blake wrote:
> I noticed this while working on the previous commit. Why should
> we be calling out '../src/' when it is sufficient to refer to just
> './'? Blind copy-and-paste runs rampant in this file :)
>
> * src/Makefile.am (INCLUDES, *_CFLAGS): Shorten to $(srcdir).
>
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>
> I'll wait for a review on this one. Let me know if I should redo
> the patch to keep trailing \ lined up in the sections where it
> started as aligned...
>
> src/Makefile.am | 112 ++++++++++++++++++++++++++++----------------------------
> 1 file changed, 56 insertions(+), 56 deletions(-)
ACK
Michal
More information about the libvir-list
mailing list