[libvirt] [PATCH] maint: in makefiles, $(top_srcdir)/src is verbose

Eric Blake eblake at redhat.com
Thu Jan 8 21:47:09 UTC 2015


On 01/08/2015 02:25 AM, Michal Privoznik wrote:
> On 08.01.2015 01:07, Eric Blake wrote:
>> I noticed this while working on the previous commit.  Why should
>> we be calling out '../src/' when it is sufficient to refer to just
>> './'?  Blind copy-and-paste runs rampant in this file :)
>>
>> * src/Makefile.am (INCLUDES, *_CFLAGS): Shorten to $(srcdir).
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>
>> I'll wait for a review on this one.  Let me know if I should redo
>> the patch to keep trailing \ lined up in the sections where it
>> started as aligned...
>>
>>   src/Makefile.am | 112
>> ++++++++++++++++++++++++++++----------------------------
>>   1 file changed, 56 insertions(+), 56 deletions(-)
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150108/9dd58731/attachment-0001.sig>


More information about the libvir-list mailing list