[libvirt] [PATCH 1/6] openvz: Resolve Coverity RESOURCE_LEAK

John Ferlan jferlan at redhat.com
Fri Jan 9 16:02:02 UTC 2015


Commit id 'a4e86390' modified the command line to allow --ipadd multiple
times, which caused Coverity to notice a latent memory leak with the
'ipAddr' string not being VIR_FREE()'d

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/openvz/openvz_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c
index c144eca..64f5219 100644
--- a/src/openvz/openvz_driver.c
+++ b/src/openvz/openvz_driver.c
@@ -911,6 +911,7 @@ openvzDomainSetNetwork(virConnectPtr conn, const char *vpsid,
         for (i = 0; i < net->nips; i++) {
             char *ipStr = virSocketAddrFormat(&net->ips[i]->address);
             virCommandAddArgList(cmd, "--ipadd", ipStr, NULL);
+            VIR_FREE(ipStr);
         }
     }
 
-- 
2.1.0




More information about the libvir-list mailing list