[libvirt] [PATCH 0/7] qemu: Job handling fixes
Ján Tomko
jtomko at redhat.com
Thu Jan 22 14:23:03 UTC 2015
On 01/22/2015 10:20 AM, Peter Krempa wrote:
> While reviewing Martin's reference counting series I've noticed a few qemu API
> impls that don't properly handle jobs.
>
> Peter Krempa (7):
> qemu: Fix job handling in qemuDomainPinVcpuFlags
> qemu: Fix job handling in qemuDomainPinEmulator
> qemu: Fix job handling in qemuDomainSetAutostart
> qemu: Fix job handling in qemuDomainSetMemoryParameters
> qemu: Fix job handling in qemuDomainSetSchedulerParametersFlags
> qemu: Fix job type in qemuDomainGetBlockIoTune
> qemu: Fix job handling in qemuDomainSetMetadata
>
> src/qemu/qemu_driver.c | 135 +++++++++++++++++++++++++++++++------------------
> 1 file changed, 87 insertions(+), 48 deletions(-)
>
In patches 1-3,5 it's necessary to check if the domain is still alive after
getting the job.
I suggest moving the BeginJob between the ACL check and
virDomainLiveConfigHelperMethod, which does check for domain liveness.
ACK with that fix.
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150122/8f4b4940/attachment-0001.sig>
More information about the libvir-list
mailing list