[libvirt] [PATCH 00/10] qemu: balloon QOM-path related cleanups

Ján Tomko jtomko at redhat.com
Thu Jun 4 13:58:05 UTC 2015


While reviewing the patch adding virtio-balloon-ccw,
I found that we are not reporting errors consistently.
This turned out to be on purpose.

This series
* moves the object path search into qemu_monitor_json
* reduces the number of allocations during search
  (more a cosmetic chagne than optimization)
* moves the balloon model checking out of the monitor code
  * vm->def should not be accessed without a virDomainObj lock
  * this should also get rid of the errors on dommemstat with
    'none' balloon reported by:
    https://www.redhat.com/archives/libvir-list/2015-May/msg01110.html
* changes qemuMonitorFindBalloonObjectPath to void
  to make it obvious that errors are ignored

Ján Tomko (10):
  Move qemuMonitorFindObjectPath to qemu_monitor_json
  Introduce qemuMonitorJSONFindLinkPath
  Remove path argument from qemuMonitorJSONFindLinkPath
  Add endjob label to qemuDomainMemoryStats
  Invert the condition in qemuDomainMemoryStats
  Only call qemuMonitorGetMemoryStats for virtio memballoon
  Check for balloon model in qemuDomainSetMemoryStatsPeriod
  Only call SetMemoryStatsPeriod for virtio memballoon
  Do not access the domain definition in
    qemuMonitorFindBalloonObjectPath
  Turn qemuMonitorFindBalloonObjectPath into a void function

 src/qemu/qemu_driver.c       |  49 +++++++++++++-----
 src/qemu/qemu_monitor.c      | 116 +++++--------------------------------------
 src/qemu/qemu_monitor_json.c |  92 ++++++++++++++++++++++++++++++++++
 src/qemu/qemu_monitor_json.h |   3 ++
 src/qemu/qemu_process.c      |   4 +-
 5 files changed, 146 insertions(+), 118 deletions(-)

-- 
2.3.6




More information about the libvir-list mailing list