[libvirt] [PATCH 1/4] libxl: don't overwrite domain state from statedir config

Jim Fehlig jfehlig at suse.com
Mon Jun 29 17:30:12 UTC 2015


When restarting libvirtd and reconnecting to running domains,
libxlReconnectDomain() would unconditionally set the domain state
to VIR_DOMAIN_RUNNING, overwriting the state maintained in
$statedir/<domname>.xml.  A domain in a paused state would have
the state changed to running, even though it was actually in a
paused state.

Signed-off-by: Jim Fehlig <jfehlig at suse.com>
---
 src/libxl/libxl_driver.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index a7be745..8a8d27d 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -372,8 +372,6 @@ libxlReconnectDomain(virDomainObjPtr vm,
                                             vm->def, VIR_HOSTDEV_SP_PCI) < 0)
         goto out;
 
-    virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_UNKNOWN);
-
     if (virAtomicIntInc(&driver->nactive) == 1 && driver->inhibitCallback)
         driver->inhibitCallback(true, driver->inhibitOpaque);
 
-- 
2.3.7




More information about the libvir-list mailing list