[libvirt] [PATCH 00/13] Move generic virsh data to a separate module vsh

[Michal Privoznik]

On 29.06.2015 17:37, Erik Skultety wrote:
> The idea behind this is that in order to introduce virt-admin client (and later
> some commands/APIs), there are lots of methods in virsh that can be easily
> reused by other potential clients like command and command argument passing or
> error reporting.
> 
> !!! IMPORTANT !!!
> These patches cannot be compiled separately, the series is split more or
> less logically into chunks only to be more readable by the reviewer.
> I started this at least 4 times from scratch and still haven't found a way that
> splitting virsh could be done with several independent applicable commits, rather
> than having one massive commit in the end.
> 
> Erik Skultety (13):
>   tools: Introduce new client generic module vsh
>   vsh: Remove client specific data, only generic data are kept
>   tools: apply s/vshX/virshX to all virsh specific data
>   virsh: remove generic data, only client specific are kept
>   virsh: Rename client specific methods in virsh.h
>   vsh: vshControl now includes client private data and client specific
>     progname
>   vsh: Make use of introduced private data
>   vsh: Introduce client hooks
>   vsh: Make use of newly introduced client side hooks
>   vsh: Introduce new global initializer
>   vsh: Make separated generic methods public
>   virsh: Introduce connection handler
>   tools: Update makefile to include 'vsh' sources as well
> 
>  cfg.mk                       |    2 +-
>  po/POTFILES.in               |    3 +-
>  tools/Makefile.am            |    4 +
>  tools/virsh-console.c        |   13 +-
>  tools/virsh-console.h        |    8 +-
>  tools/virsh-domain-monitor.c |  201 ++--
>  tools/virsh-domain-monitor.h |    4 +-
>  tools/virsh-domain.c         |  532 +++++----
>  tools/virsh-domain.h         |   14 +-
>  tools/virsh-edit.c           |    8 +-
>  tools/virsh-host.c           |  131 ++-
>  tools/virsh-interface.c      |   80 +-
>  tools/virsh-interface.h      |   12 +-
>  tools/virsh-network.c        |   72 +-
>  tools/virsh-network.h        |   10 +-
>  tools/virsh-nodedev.c        |   37 +-
>  tools/virsh-nwfilter.c       |   33 +-
>  tools/virsh-nwfilter.h       |   10 +-
>  tools/virsh-pool.c           |  104 +-
>  tools/virsh-pool.h           |   10 +-
>  tools/virsh-secret.c         |   27 +-
>  tools/virsh-snapshot.c       |   75 +-
>  tools/virsh-volume.c         |  103 +-
>  tools/virsh-volume.h         |   14 +-
>  tools/virsh.c                | 2673 ++++--------------------------------------
>  tools/virsh.h                |  481 +-------
>  tools/vsh.c                  | 2332 ++++++++++++++++++++++++++++++++++++
>  tools/vsh.h                  |  489 ++++++++
>  28 files changed, 3906 insertions(+), 3576 deletions(-)
>  create mode 100644 tools/vsh.c
>  create mode 100644 tools/vsh.h
> 

This is rather big change. Do you perhaps have a public repo with all
the patches applied?

Michal