[libvirt] [PATCH 6/6] xenapi: Resolve Coverity REVERSE_INULL

Peter Krempa pkrempa at redhat.com
Wed Mar 11 06:44:21 UTC 2015


On Tue, Mar 10, 2015 at 19:20:29 -0400, John Ferlan wrote:
> Coverity notes in xenapiDomainGetXMLDesc that 'vms' is dereferenced
> a few times before a "if (vms) xen_vm_set_free(vms);" call is made.
> Since we'd exit out much sooner if the fetch of the vms failed, just
> remove the unnecessary "if (vms)" check.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/xenapi/xenapi_driver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

ACK,

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150311/a26e0bde/attachment-0001.sig>


More information about the libvir-list mailing list