[libvirt] [PATCH] qemu: fix cannot start a vm with memory device with address
Peter Krempa
pkrempa at redhat.com
Thu Mar 26 08:24:08 UTC 2015
On Thu, Mar 26, 2015 at 14:30:56 +0800, Luyao Huang wrote:
> When start a vm which have a memory device with address, the error
> like this :
>
> error: Failed to start domain test3
> error: internal error: early end of file from monitor: possible problem:
> 2015-03-26T03:45:52.338891Z qemu-kvm: -device pc-dimm,node=0,memdev=memdimm0,
> id=dimm0,slot=0,base=4294967296: Property '.base' not found
>
> After check the qemu code i think this 'base' should named as 'addr',
> you can see this mail:
>
> http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00129.html
>
> Or check the include/hw/mem/pc-dimm.h in qemu source.
> Also add a tests for this.
>
> Signed-off-by: Luyao Huang <lhuang at redhat.com>
> ---
> I didn't change this parameter's name ('base'), because i am not sure
> if there is some special mean in it, or it is a result after
> discuss.
You are right, the "base" address has to be formatted as "addr".
>
> src/qemu/qemu_command.c | 2 +-
> .../qemuxml2argv-memory-hotplug-dimm-addr.args | 9 +++++
> .../qemuxml2argv-memory-hotplug-dimm-addr.xml | 45 ++++++++++++++++++++++
> tests/qemuxml2argvtest.c | 2 +
> 4 files changed, 57 insertions(+), 1 deletion(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm-addr.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm-addr.xml
I've reworded the commit message and pushed this patch.
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150326/0242dd4a/attachment-0001.sig>
More information about the libvir-list
mailing list