[libvirt] [PATCH 2/3] virSysinfoDef: Exempt SYSTEM variables
John Ferlan
jferlan at redhat.com
Mon May 18 18:42:27 UTC 2015
On 05/12/2015 10:56 AM, Michal Privoznik wrote:
> Move all the system_* fields into a separate struct. Not only this
> simplifies the code a bit it also helps us to identify whether BIOS
> info is present. We don't have to check all the four variables for
> being not-NULL, but we can just check the pointer to the struct.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> src/conf/domain_conf.c | 152 ++++++++++++++++++----------
> src/libvirt_private.syms | 1 +
> src/qemu/qemu_command.c | 41 ++++----
> src/util/virsysinfo.c | 258 ++++++++++++++++++++++++++++++++---------------
> src/util/virsysinfo.h | 22 ++--
> 5 files changed, 312 insertions(+), 162 deletions(-)
>
Patch 3 adds an extra line in virSysinfoSystemIsEqual after the
"while(0)" that should have been done here.
ACK with that nit adjusted
John
More information about the libvir-list
mailing list