[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: improve error message for domain stats API



On Mon, May 04, 2015 at 01:29:03PM +0200, Michal Privoznik wrote:
> On 04.05.2015 12:44, Pavel Hrdina wrote:
> > Filtering specific list of domains is not supported yet.  Print a better
> > error message.
> > 
> > old error message:
> >     error: unsupported flags (0x1) in function qemuConnectGetAllDomainStats
> > 
> > new error message:
> >     error: using filters with list of domains is not implemented yet
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1143837
> > 
> > Signed-off-by: Pavel Hrdina <phrdina redhat com>
> > Signed-off-by: Luyao Huang <lhuang redhat com>
> > ---
> > 
> > Based on https://www.redhat.com/archives/libvir-list/2014-November/msg00069.html
> > with different commit and error message.
> > 
> >  src/qemu/qemu_driver.c | 22 +++++++++++++---------
> >  1 file changed, 13 insertions(+), 9 deletions(-)
> > 
> 
> NACK. Once Peter's series is merged, this feature is implemented.
> 
> https://www.redhat.com/archives/libvir-list/2015-April/msg01561.html
> 
> Michal

That's good.  I should probably read all marked series to catch up on things and
not post another patch like this :).  I'll watch that series and close the bug
after it will get merged.

Pavel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]