[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/8] virsh: man: Add missing dashes for blockjob --bandwidth




On 04/30/2015 10:45 AM, Peter Krempa wrote:
> ---
>  tools/virsh.pod | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index f8496f3..f576fb0 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1124,10 +1124,10 @@ I<--config> or I<--current> can be specified. If no flag is specified, behavior
>  is different depending on hypervisor.
> 
>  =item B<blockjob> I<domain> I<path> { [I<--abort>] [I<--async>] [I<--pivot>] |
> -[I<--info>] [I<--raw>] [I<--bytes>] | [I<bandwidth>] }
> +[I<--info>] [I<--raw>] [I<--bytes>] | [I<--bandwidth>] }
> 
>  Manage active block operations.  There are three mutually-exclusive modes:
> -I<--info>, I<bandwidth>, and I<--abort>.  I<--async> and I<--pivot> imply
> +I<--info>, I<--bandwidth>, and I<--abort>.  I<--async> and I<--pivot> imply
>  abort mode; I<--raw> implies info mode; and if no mode was given, I<--info>
>  mode is assumed.
> 
> @@ -1151,7 +1151,7 @@ not supply bytes/s resolution; when omitting the flag, raw output is
>  listed in MiB/s and human-readable output automatically selects the
>  best resolution supported by the server.
> 
> -I<bandwidth> can be used to set bandwidth limit for the active job.
> +I<--bandwidth> can be used to set bandwidth limit for the active job.
>  Specifying a negative value is interpreted as an unsigned long long
>  value or essentially unlimited. The hypervisor can choose whether to
>  reject the value or convert it to the maximum value allowed.
> 
To add to what Eric already stated - there's multiple places with that
have [[I<--option>] {B|I}<argument>], whether you decide to go with I or
B is your choice...

Also further patches only accept a scaled bandwidth for SetSpeed, but
not for Pull, Copy, Commit (hence my 3/8 comment regarding passing
bandwidth)...

ACK - with adjustments mentioned.

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]