[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Document that virNodeGetInfo can return mhz == 0.



On Mon, May 11, 2015 at 09:30:06PM +0100, Richard W.M. Jones wrote:
> On the s/390x architecture, libvirt may already return 0 in the
> node_info->mhz field (see src/nodeinfo.c:linuxNodeInfoCPUPopulate).
> 
> We may also want to return this on aarch64 in future, because
> calculating the proper value requires SMBIOS, which is not available
> on non-server-class systems (specifically on systems which don't
> adhere to the SBSA standard).
> 
> Therefore this change documents the existing behaviour and provides a
> valid path for aarch64.
> 
> Signed-off-by: Richard W.M. Jones <rjones redhat com>
> Bug-URL: https://bugzilla.redhat.com/1206353
> ---
>  include/libvirt/libvirt-host.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

ACK

Even on x86 this can be fairly meaningless due to CPU freq scaling
in the OS

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]