[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/5] qemu: migration: selective block device migration



On Tue, May 12, 2015 at 15:07:31 +0300, Pavel Boldin wrote:
> Implement a `migrate_disks' parameters for the QEMU driver. This multi-
> value parameter can be used to explicitly specify what block devices
> are to be migrated using the NBD server. Tunnelled migration using NBD
> is to be done.
> 
...
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index eb70f29..60c09d8 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
...
> @@ -1864,9 +1884,10 @@ qemuMigrationCancelDriveMirror(virQEMUDriverPtr driver,
>      for (i = 0; i < vm->def->ndisks; i++) {
>          virDomainDiskDefPtr disk = vm->def->disks[i];
>  
> -        /* skip shared, RO and source-less disks */
> -        if (disk->src->shared || disk->src->readonly ||
> -            !virDomainDiskGetSource(disk))
> +        /* check whether disk should be migrated */
> +        /* TODO: pass migrate_disks here or loookup list of
> +         * disks under migration using some kind of qemu monitor command */
> +        if (!qemuMigrateDisk(disk, NULL))

Some of the code in this patch including this TODO will not be necessary
if https://www.redhat.com/archives/libvir-list/2015-May/msg00352.html is
accepted...

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]