[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [v3 0/2] Remove host name checking from iSCSI duplicate source checks



On 12.05.2015 04:23, John Ferlan wrote:
> Only a v3 because the first two series "Addition host name check for
> network storage pools" were not well received. If someone wants to
> pick up/use the the hostname checking code from the v2, then have at it.
> Patch 1, 2, 7, & 8 use the virSocketAddr code.
> 
> This series just focuses on the iSCSI duplicate source checks and in
> particular the removal of the host name checks to be replaced primarily
> by the duplicate source device path (or IQN) check.  For iSCSI devices,
> checking the resolved host name was not feasible. Instead, if the source
> device path (IQN) of the new definition is the same as a running pool,
> then the new definition will be rejected. The secondary check is for an
> undocumented <inititor> element to define the initiator iqn (see bz 488142).
> 
> The first patch is "new" - it's something I discovered while doing some
> extra testing with the v2 of the series.
> 
> The second patch provides the change and modifies the documentation. It
> resolves two bz's as listed in the patch description.
> 
> v2 here:
> http://www.redhat.com/archives/libvir-list/2015-April/msg01197.html
> 
> Much discussion took place in v1 though in 7/7:
> http://www.redhat.com/archives/libvir-list/2015-April/msg00880.html
> 
> John Ferlan (2):
>   conf: Adjust duplicate source host port check
>   conf: Remove source host name check for iSCSI
> 
>  docs/formatstorage.html.in | 18 ++++++++++++++----
>  docs/storage.html.in       |  8 +++++++-
>  src/conf/storage_conf.c    |  7 +++----
>  3 files changed, 24 insertions(+), 9 deletions(-)
> 

ACK series.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]