On Tue, May 12, 2015 at 07:00:07PM +0200, Pavel Hrdina wrote:
In the XML we have the vnc port number, but QEMU takes on command line a vnc screen number, it's port-5900. We should fail with error message that only ports in range [5900,65535] are valid. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1164966 Signed-off-by: Pavel Hrdina <phrdina redhat com> --- src/qemu/qemu_command.c | 96 +++++++++++++++++++++++++++---------------------- 1 file changed, 53 insertions(+), 43 deletions(-)
What a weird diff, have you used --patience for formatting? It might be worth putting a note here that the diff is best viewed using '-w' or even better '-w --word-diff' so that reviewer notices immediatelly that most of the change is just whitespace movement. ACK.
Description: PGP signature