[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 0/9] qemu: fix device alias usage, ide controllers,



On Thu, May 14, 2015 at 03:36:20PM -0400, Laine Stump wrote:
> V1 was here:
> 
>   http://www.redhat.com/archives/libvir-list/2015-May/msg00124.html
> 
> This started out with the intent to generate an error/failure on
> request for an IDE controller on a machinetype that doesn't support
> IDE (currently anything except 440fx-based machinetypes), or a 2nd IDE
> controller on a machinetype that only supports one (i.e. 440fx). This
> led to a few other related fixes, and some "fixes related to the
> related fixes".
> 
> I've pushed some of the ACKed patches, and dropped the two patches
> that changed qemuBuildDeviceAddress and qemuAssignDeviceControllerAlias
> to use switches instead of "if .. else if .." (03/13 and 04/13) and
> dropped the two SCSI patches (12/13 and 13/13), but left a couple of
> ACKed patches in for clarity.
> 
> Detailed differences from V1 in each patch.
> 
> Laine Stump (9):
>   conf: utility to return alias of a controller based on type/index
>   qemu: fix exceptions in qemuAssignDeviceControllerAlias
>   qemu: use controller alias when constructing device/controller args
>   qemu: use alias to refer to non-multibus PCI controller
>   qemu: use controller's alias in commandline for scsi-generic
>   qemu: use USB controller's alias instead of qemuUSBId()
>   qemu: remove test for allowing ide controller in s390, rename usb
>     tests
>   qemu: clean up qemuBuildCommandline loop that builds controller args
>   qemu: log error when domain has an unsupported IDE controller
> 

...

>  21 files changed, 226 insertions(+), 163 deletions(-)

ACK series.

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]