[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Introduce virDomainSetUserPassword API



On Mon, May 18, 2015 at 02:43:48PM +0200, Ján Tomko wrote:
> For setting passwords of users inside the domain.
> 
> With the VIR_DOMAIN_PASSWORD_CRYPTED flag set, the password
> is assumed to be already encrypted by crypt(3).
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1174177
> ---
>  include/libvirt/libvirt-domain.h |  9 ++++++++
>  src/access/viraccessperm.c       |  2 +-
>  src/access/viraccessperm.h       |  6 +++++
>  src/driver-hypervisor.h          |  7 ++++++
>  src/libvirt-domain.c             | 47 ++++++++++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms          |  5 +++++
>  src/remote/remote_driver.c       |  1 +
>  src/remote/remote_protocol.x     | 15 ++++++++++++-
>  src/remote_protocol-structs      |  7 ++++++
>  9 files changed, 97 insertions(+), 2 deletions(-)
> 
> diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
> index 0f465b9..b8e803d 100644
> --- a/include/libvirt/libvirt-domain.h
> +++ b/include/libvirt/libvirt-domain.h
> @@ -3818,4 +3818,13 @@ int virDomainInterfaceAddresses(virDomainPtr dom,
>  
>  void virDomainInterfaceFree(virDomainInterfacePtr iface);
>  
> +typedef enum {
> +    VIR_DOMAIN_PASSWORD_CRYPTED = 1 << 0, /* the password is crypted by crypt(3) */

nit-pick, is crypted by the method that is required by the guest OS.
This may or may not be the same as what's provided by the crypt(3)
method in the host. IOW, the user/mgmt app needs to know what the
guest OS mandates in this area.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]