[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix numatune nodeset reporting



On 19.05.2015 01:05, Martin Kletzander wrote:
> Since af2a1f0587d88656f2c14265a63fbc11ecbd924e,
> qemuDomainGetNumaParameters() returns invalid value for a running
> guest.  The problem is that it is getting the information from cgroups,
> but the parent cgroup is being left alone since the mentioned commit.
> Since the running guest's XML is in sync with cgroups, there is no need
> to look into cgroups (unless someone changes the configuration behind
> libvirt's back).  Returning the info from the definition fixes a bug and
> is also a cleanup.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1221047
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  src/qemu/qemu_driver.c | 35 ++++++++++-------------------------
>  1 file changed, 10 insertions(+), 25 deletions(-)

This is exactly what I was thinking about when I saw the bug. Whether we
should bother that somebody goes behind libvirt's back, change the
master cgroup and libvirt will not report correct info. Well, if
somebody does that, it's their problem.

ACK

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]