[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] virDomainNumatuneGetMode: Report if numatune was defined

On Tue, May 19, 2015 at 01:33:10PM +0200, Michal Privoznik wrote:
So far, we are not reporting if numatune was even defined. The
value of zero is blindly returned (which maps onto
VIR_DOMAIN_NUMATUNE_MEM_STRICT). Unfortunately, we are making
decisions based on this value. Instead, we should not inly return


the correct value, but report to the caller if the value is valid
at all.

Signed-off-by: Michal Privoznik <mprivozn redhat com>

   I know, qemuDomainGetNumaParameters() is not fixed yet, that's what the very
   next patch does.  For better view on this patch use --ignore-space-change.

I like mentioning the usability of "-w" diff flag in the commit
message, that way it's visible for people going through the history.

Anyway, ACK.

Attachment: signature.asc
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]