[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] Use virDomainDiskByName where appropriate




On 05/21/2015 07:17 AM, Ján Tomko wrote:
> On Thu, May 21, 2015 at 11:42:25AM +0200, Jiri Denemark wrote:
>> Most virDomainDiskIndexByName callers do not care about the index; what
>> they really want is a disk def pointer.
>>
>> Signed-off-by: Jiri Denemark <jdenemar redhat com>
>> ---
>>  src/libxl/libxl_driver.c  |  4 +--
>>  src/lxc/lxc_driver.c      | 10 +++-----
>>  src/qemu/qemu_agent.c     |  9 ++++---
>>  src/qemu/qemu_blockjob.c  |  5 ++--
>>  src/qemu/qemu_driver.c    | 62 ++++++++++++++++++-----------------------------
>>  src/qemu/qemu_migration.c |  6 ++---
>>  src/qemu/qemu_process.c   | 23 ++++--------------
>>  7 files changed, 42 insertions(+), 77 deletions(-)
>>
> 
> ACK series.
> 
>> @@ -18000,7 +17983,8 @@ qemuDomainSetBlockIoTune(virDomainPtr dom,
>>  
>>      if (flags & VIR_DOMAIN_AFFECT_CONFIG) {
>>          sa_assert(persistentDef);
> 
> Can we get rid of this one now?
> 
> Jan
> 

It seems so from my quick Coverity run, but hold on before pushing as
there are two new issues... I'll respond separately

John
>> -        oldinfo = &persistentDef->disks[conf_idx]->blkdeviotune;
>> +        sa_assert(conf_disk);
>> +        oldinfo = &conf_disk->blkdeviotune;
>>          if (!set_bytes) {
>>              info.total_bytes_sec = oldinfo->total_bytes_sec;
>>              info.read_bytes_sec = oldinfo->read_bytes_sec;
>>
>>
>> --
>> libvir-list mailing list
>> libvir-list redhat com
>> https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]