[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] parallels: suppress console output from parallels SDK



On Tue, May 26, 2015 at 05:57:41PM +0300, Maxim Nestratov wrote:
> It is necessary to have unpolluted screen when connecting to
> parallels driver via virsh.
> Otherwise a lot of unexpected output one will get on the console.
> 
> Signed-off-by: Maxim Nestratov <mnestratov parallels com>
> ---
>  src/parallels/parallels_sdk.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
> index 542e09e..b717ccf 100644
> --- a/src/parallels/parallels_sdk.c
> +++ b/src/parallels/parallels_sdk.c
> @@ -205,6 +205,9 @@ prlsdkInit(void)
>  {
>      PRL_RESULT ret;
>  
> +    /* Disable console output */
> +    PrlApi_SwitchConsoleLogging(0);

Does the SDK logging ever produce anything that would be useful when
troubleshooting libvirt ?

If so, you might be better to protect this with

    if (virGetEnvBlockSUID("LIBVIRT_PARALLELS_DEBUG") == NULL)
        PrlApi_SwitchConsoleLogging(0);

IOW, so people can do

  LIBVIR_PARALLELS_DEBUG=1 virsh ....

if they need to see debugging info

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]