[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] qemu: Fix compilation error when enum variable size differs from 'int'



On Tue, May 26, 2015 at 09:04:09 -0600, Eric Blake wrote:
> On 05/26/2015 02:31 AM, Peter Krempa wrote:
> > Since commit bcd9a564b631aa virDomainNumatuneGetMode returns the value
> > via a pointer rather than in the return value. The change triggered
> > problems with platforms where the compiler decides to use a data type of
> > size different than integer at the point where we typecast it.
> > 
> > Work around the issue by using an intermediate variable of the correct
> > type that gets casted back by the default typecasting rules.
> > ---
> > Version 2:
> > - removed block from the case statement
> > - added ignore value section to silence coverity and initialized the temp variable
> > 
> >  src/qemu/qemu_driver.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> ACK

Pushed; Thanks.

Peter

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]