[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage_fs: Create directory with UID if needed



On 05/27/2015 04:10 AM, Martin Kletzander wrote:
> The code already exists there, it just modified different flags.  I just
> noticed this when looking at the code.  This patch is better to view
> with bigger context or '-W'.
> 
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  src/storage/storage_backend_fs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
> index bcbbb3ae252a..5dc712925b27 100644
> --- a/src/storage/storage_backend_fs.c
> +++ b/src/storage/storage_backend_fs.c
> @@ -1,7 +1,7 @@
>  /*
>   * storage_backend_fs.c: storage backend for FS and directory handling
>   *
> - * Copyright (C) 2007-2014 Red Hat, Inc.
> + * Copyright (C) 2007-2015 Red Hat, Inc.
>   * Copyright (C) 2007-2008 Daniel P. Berrange
>   *
>   * This library is free software; you can redistribute it and/or
> @@ -807,7 +807,7 @@ virStorageBackendFileSystemBuild(virConnectPtr conn ATTRIBUTE_UNUSED,
>          (needs_create_as_uid || !virFileExists(pool->def->target.path)))
>          mode = VIR_STORAGE_DEFAULT_POOL_PERM_MODE;
>      if (needs_create_as_uid)
> -        flags |= VIR_DIR_CREATE_AS_UID;
> +        dir_create_flags |= VIR_DIR_CREATE_AS_UID;
> 
>      /* Now create the final dir in the path with the uid/gid/mode
>       * requested in the config. If the dir already exists, just set
> 

ACK, thanks for catching that

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]