[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] virsh: make negative values with vol-resize more convenient




On 05/27/2015 11:08 AM, Ján Tomko wrote:
> When shrinking a volume by a certain size, instead of typing
>   vol-resize volume 1G --delta --shrink
> we allow the convience of specifying a negative value:
>   vol-resize volume -1G --delta --shrink
> getting the same results with one more character.
> 
> A negative value only makes sense as a delta. Imply the
> --delta parameter if the value is negative.
> 
> Still require --shrink, because the operation is potentially
> destructive.
> ---
>  tools/virsh-volume.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 

Should virsh.pod be updated as well to indicate that --shrink with
negative number implies --delta (not required, but the text in virsh.pod
around this is lacking...


ACK (seemingly safe too)

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]