[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 4/9] util: multi-value virTypedParameter




On 05/26/2015 09:01 AM, Michal Privoznik wrote:
> From: Pavel Boldin <pboldin mirantis com>
> 
> The `virTypedParamsValidate' function now can be instructed to allow
> multiple entries for some of the keys. For this flag the type with
> the `VIR_TYPED_PARAM_MULTIPLE' flag.
> 
> Add unit tests for this new behaviour.
> 
> Signed-off-by: Pavel Boldin <pboldin mirantis com>
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/util/virtypedparam.c  | 108 +++++++++++++++++++-----------
>  src/util/virtypedparam.h  |  10 +++
>  tests/Makefile.am         |   6 ++
>  tests/virtypedparamtest.c | 167 ++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 252 insertions(+), 39 deletions(-)
>  create mode 100644 tests/virtypedparamtest.c
> 
> diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c
> index de2d447..ab32fc7 100644
> --- a/src/util/virtypedparam.c
> +++ b/src/util/virtypedparam.c
> @@ -47,11 +47,18 @@ VIR_ENUM_IMPL(virTypedParameter, VIR_TYPED_PARAM_LAST,
>   * internal utility functions (those in libvirt_private.syms) may
>   * report errors that the caller will dispatch.  */
>  
> +static int virTypedParamsSortName(const void *left, const void *right)

static int
virTyped...

The rest was already ACK'd in v2

John



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]