[libvirt] [PATCH 2/3] qemu: Explain mlock limit size more in detail

Peter Krempa pkrempa at redhat.com
Thu Nov 12 07:16:47 UTC 2015


On Wed, Nov 11, 2015 at 15:23:55 +0100, Andrea Bolognani wrote:
> On Wed, 2015-11-11 at 06:57 +0100, Peter Krempa wrote:
> > Based on Alex's explanation [1] in the recent discussion let's update
> > the comment explaining the memory lock limit calculation.
> > 
> > [1]
> > http://www.redhat.com/archives/libvir-list/2015-November/msg00329.html
> 
> I'd rather have the reference to Alex's explanation as part of
> the comment itself, so that it's easier to look up later
> without having to dig through the git log, but that's just my
> personal preference.

It makes sense. I've added it to the commit message.

> 
> > ---
> >  src/qemu/qemu_domain.c | 19 ++++++++++++++++---
> >  1 file changed, 16 insertions(+), 3 deletions(-)
> > 
> 
> ACK with the typos fixed.

Fixed the typos and pushed. Thanks.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151112/591fdce9/attachment-0001.sig>


More information about the libvir-list mailing list