[libvirt] [PATCH] bhyve: monitor: do not override domain's privateData

Daniel P. Berrange berrange at redhat.com
Mon Nov 16 12:45:17 UTC 2015


On Wed, Nov 04, 2015 at 06:08:00PM +0300, Roman Bogorodskiy wrote:
> Current monitor code overrides domain object's privateData, e.g.
> in virBhyveProcessStart():
> 
>   vm->privateData = bhyveMonitorOpen(vm, driver);
> 
> where bhyveMonitorPtr() returns bhyveMonitorPtr.
> 
> This is not right thing to do, so make bhyveMonitorPtr
> a part of the bhyveDomainObjPrivate struct and change related code
> accordingly.
> ---
>  src/bhyve/bhyve_domain.h  |  4 ++++
>  src/bhyve/bhyve_monitor.c | 36 +++++++++++++++++++-----------------
>  src/bhyve/bhyve_process.c | 11 +++++++----
>  3 files changed, 30 insertions(+), 21 deletions(-)

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list