[libvirt] [PATCH v1 02/23] security_dac: Fix TODO marks

Michal Privoznik mprivozn at redhat.com
Mon Oct 12 10:25:47 UTC 2015


Correctly mark the places where we need to remember and recall
file ownership. We don't want to mislead any potential developer.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/security/security_dac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 864d75b..0dfe570 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@@ -312,6 +312,7 @@ virSecurityDACSetOwnershipInternal(virSecurityDACDataPtr priv,
 static int
 virSecurityDACSetOwnership(const char *path, uid_t uid, gid_t gid)
 {
+    /* XXX record previous ownership */
     return virSecurityDACSetOwnershipInternal(NULL, NULL, path, uid, gid);
 }
 
@@ -324,7 +325,7 @@ virSecurityDACRestoreSecurityFileLabelInternal(virSecurityDACDataPtr priv,
     VIR_INFO("Restoring DAC user and group on '%s'",
              NULLSTR(src ? src->path : path));
 
-    /* XXX record previous ownership */
+    /* XXX recall previous ownership */
     return virSecurityDACSetOwnershipInternal(priv, src, path, 0, 0);
 }
 
-- 
2.4.9




More information about the libvir-list mailing list