[libvirt] [PATCH v1 10/23] lock_daemon: Switch to wrapper locking functions

Peter Krempa pkrempa at redhat.com
Fri Oct 16 06:27:35 UTC 2015


On Mon, Oct 12, 2015 at 12:25:55 +0200, Michal Privoznik wrote:
> Lets use wrapper functions virLockDaemonLock and
> virLockDaemonUnlock instead of virMutexLock and virMutexUnlock.
> This has no functional impact, but it's easier to read (at least
> for me).

Actually we removed such helpers in favor of virObjectLock in most
places.

On the other hand, converting a singleton to virObject is a waste of
resources.

> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/locking/lock_daemon.c | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)
> 

Reluctant ACK if you add a 'inline' keyword.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151016/e20d31e6/attachment-0001.sig>


More information about the libvir-list mailing list