[libvirt] [PATCH v6 11/11] quorum: Block snapshot operation with RAID

[Matthias Gatto]

On Thu, Oct 29, 2015 at 2:43 PM, Matthias Gatto
<matthias.gatto at outscale.com> wrote:
> For now we block all snapshot operations with quorum, because it would require
> a lot more code, espacially because Qemu doesn't really suport it.
>
> I guess, we can use node-name, and manually snapshoot all qcow from a
> virStorageSource and use this as a quorum's snapshot,
> but libvirt doesn't support node-name, and we don't need node-name
> anymore to use a quorum in qemu.
>
> I actually have some patchs which could partially support quorum snapshot
> on my computer, but nothing suitable to be upstream, so I prefer to have
> a stable versions of quorum inside libvirt before dealling with
> snapshot.
>
> Signed-off-by: Matthias Gatto <matthias.gatto at outscale.com>
> ---
>  src/qemu/qemu_driver.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 25be0d9..0e43966 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -14674,6 +14674,12 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,
>      if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
>          goto cleanup;
>
> +    if (virDomainDefHasRAID(vm->def)) {
> +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> +                       _("Snapshot does not support domain with RAID(like quorum) yet"));
> +        goto cleanup;
> +    }
> +
>      if (qemuProcessAutoDestroyActive(driver, vm)) {
>          virReportError(VIR_ERR_OPERATION_INVALID,
>                         "%s", _("domain is marked for auto destroy"));
> --
> 2.6.1
>

Oups, I've send this patch twice, sorry for my mistake.

This one is not the good one, the good one is this one:
http://www.redhat.com/archives/libvir-list/2015-October/msg00863.html