[libvirt] [PATCH sandbox v5 06/20] Image: Add download function

Daniel P. Berrange berrange at redhat.com
Wed Sep 9 12:28:37 UTC 2015


On Wed, Sep 09, 2015 at 02:19:20PM +0200, Cedric Bosdonnat wrote:
> On Wed, 2015-09-09 at 12:55 +0100, Daniel P. Berrange wrote:
> > On Wed, Sep 09, 2015 at 01:50:11PM +0200, Cedric Bosdonnat wrote:
> > > This wording really sounds docker-specific. The registry word only fits
> > > docker terminology, would surely not apply to virt-builder or appc case.
> > > Something like "images storage" would may be more generic. The problem
> > > is that "repository" has a special meaning in the docker terminology.
> > 
> > Yeah, I was thinking we might need some way to let source subclasses
> > add custom arguments. eg so we'd have  --docker-registry.
> > 
> > The appc spec doesn't have a concept of a central registry in the
> > same way as docker. Instead the image name encodes the domain
> > name, eg   example.com/someapp, and there's a protocol to use
> > this to identify the server, and then resolve the download URL
> > 
> > > ACK, but may need some thinking on the "Registry" word.
> > 
> > I'm inclined to merge this, and then fix it afterwards to be more
> > generic
> 
> Sure... but then we surely don't want to get a release out with the
> temporary parameter.

Oh definitely not. I'm not intending todo a release immediately. I want
some time to play around with this code and clean up more stuff before
we release it and get stuck with the syntax.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list