[libvirt] [PATCH] libxl: fix AttachDeviceConfig on hostdev type

[Jim Fehlig]

On 09/16/2015 11:17 PM, Chunyan Liu wrote:
> After attach-device a <hostdev> with --config, new device doesn't
> show up in dumpxml and in guest.
>
> To fix that, set dev->data.hostdev = NULL after work so that the
> pointer is not freed, since vmdef has the pointer and still need it.
>
> Signed-off-by: Chunyan Liu <cyliu at suse.com>
> ---
>   src/libxl/libxl_driver.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index e2797d5..8087c27 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -3312,6 +3312,7 @@ libxlDomainAttachDeviceConfig(virDomainDefPtr vmdef, virDomainDeviceDefPtr dev)
>   
>               if (virDomainHostdevInsert(vmdef, hostdev) < 0)
>                   return -1;
> +            dev->data.hostdev = NULL;

Nice catch, ACK. Thanks for the patch! I've pushed it now.

Regards,
Jim