[libvirt] [PATCH] qemu: Check for gnutls_rnd() explicitly
Andrea Bolognani
abologna at redhat.com
Thu Apr 7 12:28:56 UTC 2016
On Thu, 2016-04-07 at 13:57 +0200, Andrea Bolognani wrote:
> Our use of gnutls_rnd() is conditional to the availability of
> the <gnutls/crypto.h> header file.
>
> Such check, however, turns out not to be strict enough as there
> are some versions of gnutls (eg. 2.8.5 as available in CentOS 6)
> that provide the header file, but not the function itself, which
> was introduced in 2.12.0.
>
> Introduce an explicit check for the function itself.
> ---
> Would qualify as a build breaker (see [1]) but I'd rather have
> some feedback before pushing it.
>
> [1] https://ci.centos.org/view/libvirt-project/job/libvirt-daemon-build/systems=libvirt-centos-6/1120/
SNACK
John pointed out that HAVE_GNUTLS_RND is never defined, so while
this technically still fixes the build breakage, it's not really
the patch we're looking for :)
I'll try to figure out how to make it work properly. Suggestions
are always welcome.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team
More information about the libvir-list
mailing list