[libvirt] [PATCH 2/2] configure: Make virt-host-validate optional

Martin Kletzander mkletzan at redhat.com
Mon Apr 11 10:25:13 UTC 2016


On Mon, Apr 11, 2016 at 11:29:51AM +0200, Andrea Bolognani wrote:
>On Mon, 2016-04-11 at 10:48 +0200, Martin Kletzander wrote:
>> I haven't looked that much into it, but I don't think we should put the
>> generated man pages into the dist, but rather the .pod files and that
>> are there by default, right?  Could just removing the:
>> 
>>   EXTRA_DIST += virt-host-validate.1
>> 
>> be enough to fix what Cole saw happen?
>
>We want to ship the generated man pages so that users don't need
>to have pod2man(1) installed on their system.
>
>Anyway, the problem is just that a hunk got lost while shuffling
>commits around. After squashing it in distcheck works again for
>me.
>
>Cheers.
>
>
>diff --git a/tools/Makefile.am b/tools/Makefile.am
>index ab37d70..560a9a5 100644
>--- a/tools/Makefile.am
>+++ b/tools/Makefile.am
>@@ -67,7 +67,6 @@ bin_SCRIPTS = virt-xml-validate virt-pki-validate
> bin_PROGRAMS = virsh virt-admin
> libexec_SCRIPTS = libvirt-guests.sh
> dist_man1_MANS = \
>-               virt-host-validate.1 \
>                virt-pki-validate.1 \
>                virt-xml-validate.1 \
>                virsh.1 \
>-- 

Yes, or that ^^ if we don't require pod2man =) That's fine with me, but
I don't have mingw build working, so I'll leave it to others to properly
ACK it.

>Andrea Bolognani
>Software Engineer - Virtualization Team
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160411/4039368f/attachment-0001.sig>


More information about the libvir-list mailing list