[libvirt] [PATCH 3/6] vz: handle sourceless cdroms

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Thu Apr 14 15:02:52 UTC 2016



On 28.03.2016 11:00, Nikolay Shirokovskiy wrote:
> From: Mikhail Feoktistov <mfeoktistov at virtuozzo.com>
> 
> SDK handles empty cdroms all right. We just need to
> pass "" instead of NULL (not setting is good too).
> 
> However we can get problems here. Disk detaching treats source
> as ids. Fortunately disk detaching is not supported for cdroms
> yet and for hard disks we can not get empty source - this is prohibitited
> by xml parsing code.
> 
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---
>  src/vz/vz_sdk.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)

Please drop this patch from the series. I sent a new version as
a standalone patch.

Nikolay
 




More information about the libvir-list mailing list