[libvirt] [libvirt-php PATCH 03/29] add missing arginfo

[Michal Privoznik]

On 13.04.2016 18:13, Neal Gompa wrote:
> From: Remi Collet <fedora at famillecollet.com>
> 
> ---
>  src/libvirt-php.c | 715 +++++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 553 insertions(+), 162 deletions(-)
> 
> diff --git a/src/libvirt-php.c b/src/libvirt-php.c
> index 1af6077..3f06edc 100644
> --- a/src/libvirt-php.c
> +++ b/src/libvirt-php.c


> @@ -5984,7 +6371,7 @@ PHP_FUNCTION(libvirt_domain_memory_peek)
>      zval *zdomain;
>      int retval;
>      long flags=0;
> -    long long start;
> +    long start;

This is spurious for two reasons:
1) this patch aims at something different. So this change does not
belong here.
2) The @start variable is passed to virDomainMemoryPeek(). It expects
unsigned long long. So this change does not belong here.

>      long size;
>      char *buff;
>  

Michal