[libvirt] [PATCH] qemu: migration: Drop dead VNC cookie handling

Peter Krempa pkrempa at redhat.com
Fri Apr 15 08:07:37 UTC 2016


On Tue, Apr 12, 2016 at 17:00:40 -0400, Cole Robinson wrote:
> The only caller of this code is:
> 
>     for (i = 0; i < dom->def->ngraphics; i++) {
>        if (dom->def->graphics[i]->type == VIR_DOMAIN_GRAPHICS_TYPE_SPICE) {
>            if (!(mig->graphics =
>                  qemuMigrationCookieGraphicsAlloc(driver, dom->def->graphics[i])))
>                return -1;
>            mig->flags |= QEMU_MIGRATION_COOKIE_GRAPHICS;
>            break;
>        }
>     }
> 
> So this is never triggered for VNC, and in fact VNC has no support for
> seamless migration anyways so that seems correct. Drop the dead VNC
> handling.
> ---
>  src/qemu/qemu_migration.c | 34 +++++++++++-----------------------
>  1 file changed, 11 insertions(+), 23 deletions(-)
> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 8d2ca3b..ca3619d 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -320,33 +320,21 @@ qemuMigrationCookieGraphicsAlloc(virQEMUDriverPtr driver,

In that case this function should be called
qemuMigrationCookieGraphicsSpiceAlloc.

ACK with that change.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160415/c689c1dd/attachment-0001.sig>


More information about the libvir-list mailing list