[libvirt] [PATCH v2] Include sysmacros.h where needed

[Martin Kletzander]

On Fri, Apr 15, 2016 at 02:26:09PM +0200, Peter Krempa wrote:
>On Fri, Apr 15, 2016 at 09:21:49 +0200, Martin Kletzander wrote:
>> So in glibc-2.23 sys/sysmacros.h is no longer included from sys/types.h
>> and we don't build because of the usage of major/minor/makedev macros.
>> Autoconf already has AC_HEADER_MAJOR macro that check where exactly
>> these functions/macros are defined, so let's use that.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>> v2:
>>  - Don't include the file unconditionally, but rather use
>>    AC_HEADER_MAJOR that exists for exactly this purpose.
>>
>> v1:
>>  - https://www.redhat.com/archives/libvir-list/2016-April/msg00851.html
>>
>>  configure.ac             | 2 ++
>>  src/conf/domain_audit.c  | 6 ++++++
>>  src/lxc/lxc_controller.c | 7 +++++++
>>  src/lxc/lxc_driver.c     | 7 +++++++
>>  src/util/vircgroup.c     | 7 +++++++
>>  src/util/virutil.c       | 7 +++++++
>>  tests/vircgroupmock.c    | 7 +++++++
>>  7 files changed, 43 insertions(+)
>
>I've just found out about the breakage by upgrading glibc and almost
>blamed you as I've misunderstood this patch.
>
>This fixes the build for me and the usage of AC_HEADER_MAJOR looks on
>the spot to me.
>
>ACK

Thanks but you're not the only one, so let's wait for the consensus to
be reached.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160415/9198b65f/attachment-0001.sig>