[libvirt] [PATCH 0/4] qemu: handle ',' and '=' in VM names

[John Ferlan]

On 04/22/2016 06:46 PM, Cole Robinson wrote:
> This series adds qemu cli comma escaping to several places that
> are dependent on the VM name, to enable names with embedded commas.
> 
> Patch 4 makes use of qemu -name guest=X value to allow names with
> '=' in them.
> 
> There's likely other places that are VM name dependent that need
> escaping too, but this hits the mandatory ones. I'm going to through
> the remaining list on the BiteSizedTasks page
> 
> Cole Robinson (4):
>   qemu: command: escape commas in VM name
>   qemu: command: escape commas in secret master path
>   qemu: command: escape commas in chardev socket path
>   qemu: command: Use -name guest= if available
> 
>  src/qemu/qemu_capabilities.c                       |  2 ++
>  src/qemu/qemu_capabilities.h                       |  1 +
>  src/qemu/qemu_command.c                            | 22 ++++++++++++--------
>  tests/qemucapabilitiesdata/caps_2.1.1-1.caps       |  1 +
>  tests/qemucapabilitiesdata/caps_2.4.0-1.caps       |  1 +
>  tests/qemucapabilitiesdata/caps_2.5.0-1.caps       |  1 +
>  tests/qemucapabilitiesdata/caps_2.6.0-1.caps       |  1 +
>  .../qemuxml2argvdata/qemuxml2argv-name-escape.args | 24 ++++++++++++++++++++++
>  .../qemuxml2argvdata/qemuxml2argv-name-escape.xml  | 18 ++++++++++++++++
>  tests/qemuxml2argvtest.c                           |  2 ++
>  10 files changed, 65 insertions(+), 8 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-name-escape.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-name-escape.xml
> 


Is "ewww" the proper word here ;-)

What about the vmagent path?

Since the 'path' that the masterKey uses is essentially the priv->libDir
path, would fixing that path to have escaped chars work? (just typing
without researching, thinking)... Similarly channelTargetDir. IOW:
qemuDomainSetPrivatePaths

What about places in qemu_process which use the [obj->]def->name to
build Path's (stateDir).

Does this work with domain name rename?  migrations? If the target host
doesn't support "guest=".

I guess I'm also somewhat surprised that there'd be no issues w/ cgroups
and systemd interactions.

Just some quick Saturday morning thoughts with only 1 cup of coffee...

John