[libvirt] [PATCH] remote: Don't reject remote polkit if client lacks support

Daniel P. Berrange berrange at redhat.com
Tue Apr 26 15:13:04 UTC 2016


On Thu, Apr 14, 2016 at 03:41:22PM -0400, Cole Robinson wrote:
> If you compile a client --without-polkit, and connect to a URI that needs
> polkit auth, the connection will fail with:
> 
> $ ./tools/virsh --connect qemu+ssh://crobinso@machine/system
> error: failed to connect to the hypervisor
> error: authentication failed: unsupported authentication type 2
> 
> This is because the client side portion of the polkit handling is
> compiled out. However, nothing polkit specific is actually required
> of the client.
> 
> Fix that error by unconditionally compiling the basic polkit client
> handling.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=635529
> ---
> Granted, if polkit needs to do any interaction at all, and you are
> connecting to a remote machine, then things are going to fail anyways
> with a 'missing agent' error. But if you're user is in the 'libvirt'
> group polkit doesn't need to auth it should all work.
> 
> 
>  src/remote/remote_driver.c | 69 +++++++++++++++++++++-------------------------
>  1 file changed, 31 insertions(+), 38 deletions(-)

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list