[libvirt] [PATCH 3/2] qemu: cap: Refactor access to array in virQEMUCapsProbeQMPMachineTypes

Ján Tomko jtomko at redhat.com
Mon Aug 1 07:33:52 UTC 2016


On Fri, Jul 29, 2016 at 10:40:57AM +0200, Peter Krempa wrote:
>Use a temporary pointer rather than always recalculating the index in a
>very verbose way.
>---
> src/qemu/qemu_capabilities.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
>diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
>index 23d4a65..c612960 100644
>--- a/src/qemu/qemu_capabilities.c
>+++ b/src/qemu/qemu_capabilities.c
>@@ -2473,6 +2473,7 @@ static int
> virQEMUCapsProbeQMPMachineTypes(virQEMUCapsPtr qemuCaps,
>                                 qemuMonitorPtr mon)
> {
>+    struct virQEMUCapsMachineType *mach;

Declaring this variable inside the for loop would be nicer, since it's
only used there.

Jan




More information about the libvir-list mailing list